Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix map function returning undefined. #393

Merged
merged 1 commit into from
Jul 13, 2016
Merged

WIP: Fix map function returning undefined. #393

merged 1 commit into from
Jul 13, 2016

Conversation

dahjelle
Copy link
Contributor

@dahjelle dahjelle commented Jul 12, 2016 •
edited
Loading

What's the preferred kind of test case for this, where a map function unintentionally returned undefined? I added one, but it seems…strange.

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo
Copy link
Contributor

I think that's a pretty reasonable test! You have a typescript error in your code, I think you can avoid it by using square brackets ['TodoList5']['__typename'] instead of the dot notation.

I'd suggest running the tests locally with npm test before opening a PR.

Thanks for finding this bug!

@dahjelle dahjelle force-pushed the removeRefsFromStore branch from 5d1bc0e to 3c76a1b Compare July 13, 2016 01:32
@dahjelle
Copy link
Contributor Author

@stubailo

I'd suggest running the tests locally with npm test before opening a PR.

Thanks. I wasn't paying enough attention—sorry 'bout that!

Should be updated & ready to go!

@stubailo
Copy link
Contributor

This branch is out-of-date with the base branch

Hmm, I wonder how this happened - maybe you didn't pull all of the changes before merging/rebasing?

@dahjelle dahjelle force-pushed the removeRefsFromStore branch from 3c76a1b to 4371e7f Compare July 13, 2016 01:46
@dahjelle
Copy link
Contributor Author

I think #396 landed between my rebase and my push. Rebased again.

@stubailo
Copy link
Contributor

Wow it's pretty silly. I guess github protected branches can be pretty annoying, but so far it seems to help more than it hurts...

@stubailo stubailo merged commit 16a49d9 into apollographql:master Jul 13, 2016
@stubailo
Copy link
Contributor

Thanks a lot for doing this and putting up with the process!

@dahjelle
Copy link
Contributor Author

👍

@dahjelle dahjelle deleted the removeRefsFromStore branch July 13, 2016 02:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahjelle @stubailo